feat: add configurable health check point - #192
Closed
ShuranZhang wants to merge 1 commit into
Closed
Conversation
ShuranZhang
force-pushed
the
health-check-endpoint
branch
5 times, most recently
from
August 11, 2025 22:08
271be8c to
5e7acb4
Compare
mayurkale22
reviewed
Aug 12, 2025
mayurkale22
reviewed
Aug 12, 2025
ShuranZhang
force-pushed
the
health-check-endpoint
branch
from
August 13, 2025 17:48
5e7acb4 to
26d3d15
Compare
pabloecol
reviewed
Aug 15, 2025
| } | ||
|
|
||
| @Test | ||
| public void testHealthServerReturnsOk() throws Exception { |
Collaborator
There was a problem hiding this comment.
could you also add a test to confirm that the adapter starts ok but there is no health check server if the health check port is not provided?
| final String maxCommitDelayProperty = System.getProperty(MAX_COMMIT_DELAY_PROP_KEY); | ||
| final boolean enableBuiltInMetrics = | ||
| Boolean.parseBoolean(System.getProperty(ENABLE_BUILTIN_METRICS_PROP_KEY, "false")); | ||
| final int healthCheckPort = |
Collaborator
There was a problem hiding this comment.
might be better to make this an Integer and check for null instead of 0 in start()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose a new int config
healthCheckPort.localhost:9042, you set-DhealthCheckPort=8080, the health server sits onlocalhost:8080/debug/health)./debug/healthpath of this endpointwill not be registered and no readiness checks will be available via HTTP.