Skip to content

feat: Add env var to log server errors #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ath-08 merged 3 commits into from
Aug 25, 2025
Merged

feat: Add env var to log server errors #198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e224499
feat: Add env var to log server errors
mayurkale22 Aug 22, 2025
5b99c91
fix comments
mayurkale22 Aug 23, 2025
5dee0ee
fix comment
mayurkale22 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion ...ner-cassandra/src/main/java/com/google/cloud/spanner/adapter/DriverConnectionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import com.datastax.oss.protocol.internal.request.Batch;
import com.datastax.oss.protocol.internal.request.Execute;
import com.datastax.oss.protocol.internal.request.Query;
import com.datastax.oss.protocol.internal.response.Error;
import com.google.api.gax.grpc.GrpcCallContext;
import com.google.api.gax.rpc.ApiCallContext;
import com.google.cloud.spanner.adapter.metrics.BuiltInMetricsRecorder;
Expand Down Expand Up @@ -66,6 +67,8 @@ final class DriverConnectionHandler implements Runnable {
private static final ByteBufAllocator byteBufAllocator = ByteBufAllocator.DEFAULT;
private static final FrameCodec<ByteBuf> serverFrameCodec =
FrameCodec.defaultServer(new ByteBufPrimitiveCodec(byteBufAllocator), Compressor.none());
private static final FrameCodec<ByteBuf> clientFrameCodec =
FrameCodec.defaultClient(new ByteBufPrimitiveCodec(byteBufAllocator), Compressor.none());
private final Socket socket;
private final AdapterClientWrapper adapterClientWrapper;
private final Optional<String> maxCommitDelayMillis;
Expand All @@ -79,6 +82,12 @@ final class DriverConnectionHandler implements Runnable {
private static final GrpcCallContext DEFAULT_CONTEXT_WITH_LAR =
GrpcCallContext.createDefault().withExtraHeaders(ROUTE_TO_LEADER_HEADER_MAP);
private static final byte[] EMPTY_BYTES = new byte[0];
private static final String ENV_VAR_GOOGLE_SPANNER_CASSANDRA_LOG_SERVER_ERRORS =
"GOOGLE_SPANNER_CASSANDRA_LOG_SERVER_ERRORS";
private static final boolean LOG_SERVER_ERRORS =
Boolean.parseBoolean(
System.getenv()
.getOrDefault(ENV_VAR_GOOGLE_SPANNER_CASSANDRA_LOG_SERVER_ERRORS, "false"));

/**
* Constructor for DriverConnectionHandler.
Expand Down Expand Up @@ -164,7 +173,13 @@ private void processRequestsLoop(InputStream inputStream, OutputStream outputStr
prepareResult.getAttachments(),
prepareResult.getContext(),
streamId);
// Now response holds the gRPC result, which might still be empty.
if (LOG_SERVER_ERRORS) {
Frame frame = decodeClientFrame(response.toByteArray());
if (frame.message instanceof Error) {
Comment thread
ath-08 marked this conversation as resolved.
Error error = (Error) frame.message;
LOG.info("ERROR: code: {}, message: {}", error.code, error.message);
}
}
}
} catch (RuntimeException e) {
// 5. Handle any error during payload construction or attachment processing.
Expand Down Expand Up @@ -288,6 +303,13 @@ private Frame decodeFrame(byte[] payload) {
return frame;
}

private Frame decodeClientFrame(byte[] payload) {
ByteBuf payloadBuf = Unpooled.wrappedBuffer(payload);
Frame frame = clientFrameCodec.decode(payloadBuf);
payloadBuf.release();
return frame;
}

/**
* Attempts to prepare the given payload prior to sending the request.
*
Expand Down
Loading