Skip to content

chore: Add multithreaded integration test. - #199

Merged
ath-08 merged 2 commits into
mainfrom
multithreaded-it
Aug 25, 2025
Merged

chore: Add multithreaded integration test.#199
ath-08 merged 2 commits into
mainfrom
multithreaded-it

Conversation

@ath-08

@ath-08 ath-08 commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Adding this multithreaded test to ensure that the payload and response processing is proper and we are not overwriting anything. There are several cases where we are avoiding making copies of data to make the client more performant. The data might be processed in multiple threads, so it increases the risk of unintentional overwrite. This test will help detect such mistakes.

@ath-08
ath-08 requested a review from mayurkale22 August 22, 2025 20:58
@mayurkale22

Copy link
Copy Markdown
Collaborator

Could you pls add details in desc about reasoning for this change?

@mayurkale22
mayurkale22 requested a review from pabloecol August 25, 2025 05:28
@ath-08

ath-08 commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

Could you pls add details in desc about reasoning for this change?

Added.

mayurkale22
mayurkale22 previously approved these changes Aug 25, 2025
@mayurkale22

Copy link
Copy Markdown
Collaborator

ITs are failing, pls check

@ath-08
ath-08 force-pushed the multithreaded-it branch 4 times, most recently from 7901e15 to 2b8c645 Compare August 25, 2025 23:11
@ath-08
ath-08 requested a review from mayurkale22 August 25, 2025 23:19
@ath-08

ath-08 commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

Could you pls add details in desc about reasoning for this change?

Done.

@ath-08

ath-08 commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

ITs are failing, pls check

Fixed.

@ath-08
ath-08 merged commit e4ff0bb into main Aug 25, 2025
16 checks passed
@ath-08
ath-08 deleted the multithreaded-it branch August 25, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants