feat: Support YAML configuration for Launcher - #211
Merged
Conversation
pabloecol
requested review from
ShuranZhang,
ath-08 and
mayurkale22
and removed request for
ShuranZhang
September 3, 2025 03:06
pabloecol
force-pushed
the
launcher-configs
branch
from
September 3, 2025 03:48
d9b060b to
d1a2f3d
Compare
Introduces the ability to configure the Spanner Cassandra Adapter Launcher using a YAML file. This provides a more flexible and powerful way to configure the adapter, especially for production environments and setups with multiple listeners. The Launcher can now be configured via a `-DconfigFilePath` system property that points to a YAML file. The YAML file supports global settings and multiple listener configurations. The existing system property-based configuration is retained for simpler, single-listener setups. The `README.md` has been updated to document both configuration methods, and new unit tests have been added to cover the YAML configuration loading and parsing logic.
pabloecol
force-pushed
the
launcher-configs
branch
from
September 3, 2025 04:20
d1a2f3d to
a4178c0
Compare
mayurkale22
reviewed
Sep 3, 2025
mayurkale22
reviewed
Sep 3, 2025
mayurkale22
reviewed
Sep 3, 2025
ath-08
reviewed
Sep 3, 2025
mayurkale22
reviewed
Sep 4, 2025
mayurkale22
reviewed
Sep 4, 2025
mayurkale22
reviewed
Sep 5, 2025
mayurkale22
left a comment
mayurkale22
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making changes. LGTM, added last rounds of comments
mayurkale22
reviewed
Sep 5, 2025
mayurkale22
left a comment
mayurkale22
left a comment
Collaborator
There was a problem hiding this comment.
last comment, otherwise LGTM
mayurkale22
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the ability to configure the Spanner Cassandra Adapter Launcher using a YAML file. This provides a more flexible and powerful way to configure the adapter, especially for production environments and setups with multiple listeners.
The Launcher can now be configured via a
-DconfigFilePathsystem property that points to a YAML file. The YAML file supports global settings and multiple listener configurations. The existing system property-based configuration is retained for simpler, single-listener setups.The
README.mdhas been updated to document both configuration methods, and new unit tests have been added to cover the YAML configuration loading and parsing logic.