This repository was archived by the owner on Aug 30, 2026. It is now read-only.
chore: reduce test time by skipping mtls - #4022
Closed
olavloite wants to merge 3 commits into
Closed
Conversation
The Google Auth libraries have added support for mtls. A check for what type of MtlsProvider is available is executed multiple times every time a Spanner client is created, and this check is relatively expensive. This causes all mock server tests to become slow. This change introduces a temporary hack to work around this, until we have a solution in the auth libraries that allow us to turn off this feature during tests that do not care about mtls.
product-auto-label
Bot
added
size: m
rahul2393
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Google Auth libraries have added support for mtls. A check for what type of MtlsProvider is available is executed multiple times every time a Spanner client is created, and this check is relatively expensive. This causes all mock server tests to become slow.
This change introduces a temporary hack to work around this, until we have a solution in the auth libraries that allow us to turn off this feature during tests that do not care about mtls.