fix: ship CJS .d.cts types for require consumers - #1834
Open
edenbuilds wants to merge 3 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
TypeScript treats shared .d.ts as ESM when package.json has "type":"module", so CJS consumers hit TS1479 despite a working .index.cjs. Nest types under import/require and emit matching .d.cts. Fixes googleapis#1811
edenbuilds
force-pushed
the
fix/cjs-dual-types-1811
branch
from
August 7, 2026 18:38
7b966fc to
3b07a34
Compare
Update branch with upstream main to clear GitHub BEHIND state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typesunderimport/requireconditions and emit.d.ctscompanions so TypeScript CJS consumers no longer hit TS1479 whilerequire()already resolves to a working.cjs.scripts/copy_cjs_types.jscopies public.d.tsrollups to.d.cts;filesand Rollup export-path resolution updated accordingly.Test plan
@google/genai@2.16.0→tscwithmodule: node16(CJS package) fails TS1479; same tree with nested exports +.d.ctscopies → clean.node scripts/copy_cjs_types.jsafter api-extractor.Fixes #1811