feat: add engine methods#256
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
the
api: cloudsql-postgres
| ) | ||
| ) | ||
|
|
||
| async def _ainit_checkpoint_table( |
There was a problem hiding this comment.
From work with Fernando, we should support a custom table name so testing is easier, but keep it defaulting to the table names.
There was a problem hiding this comment.
Hello @averikitsch, I changed the method, please let me know if the changes work for you.
|
/gcbrun |
| checkpoints_table_name: str = CHECKPOINTS_TABLE, | ||
| checkpoint_writes_table_name: str = CHECKPOINT_WRITES_TABLE, |
There was a problem hiding this comment.
Can we simplify this to
| checkpoints_table_name: str = CHECKPOINTS_TABLE, | |
| checkpoint_writes_table_name: str = CHECKPOINT_WRITES_TABLE, | |
| table_name: str = CHECKPOINTS_TABLE, | |
| writes_table_name: str = CHECKPOINT_WRITES_TABLE, |
|
/gcbrun |
tests/test_engine.py
Outdated
| assert engine | ||
| await aexecute(engine, "SELECT 1") | ||
| await engine.close() | ||
| await engine._connector.close() |
There was a problem hiding this comment.
Remove the close here. We will close the connector above.
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
3 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕