Skip to content

Comments

feat: add checkpoint postgresql#262

Closed
carloszuag wants to merge 13 commits intogoogleapis:langgraph-basefrom
carloszuag:checkpoint_postgresql
Closed

feat: add checkpoint postgresql#262
carloszuag wants to merge 13 commits intogoogleapis:langgraph-basefrom
carloszuag:checkpoint_postgresql

Conversation

@carloszuag
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@carloszuag carloszuag requested review from a team as code owners January 31, 2025 20:31
@google-cla
Copy link

google-cla bot commented Jan 31, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Jan 31, 2025
@carloszuag carloszuag changed the title Checkpoint postgresql feat: add checkpoint postgresql Feb 5, 2025
requirements.txt Outdated
Comment on lines 7 to 11
aiohttp~=3.11.11
asyncpg~=0.30.0
langgraph~=0.2.68
pytest~=8.3.4
pytest-asyncio~=0.25.2 No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these dependencies. The test dependencies are defined in the pyproejct.toml. We will only need to keep langgraph-checkpoint so we can test against it.

self.schema_name = schema_name

@classmethod
async def create(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create will also have to support a custom table name for the tests to work

}
}

query = f"""INSERT INTO "{self.schema_name}".{CHECKPOINTS_TABLE}(thread_id, checkpoint_ns, checkpoint_id, parent_checkpoint_id, checkpoint, metadata)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add quotes around table name

@averikitsch averikitsch mentioned this pull request Feb 7, 2025
4 tasks
@averikitsch
Copy link
Collaborator

Closing in favor of #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants