Merged
Conversation
product-auto-label
bot
added
the
api: cloudsql-postgres
vishwarajanand
added
the
do not merge
vishwarajanand
removed
the
do not merge
1 task
dishaprakash
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of connectors are leading to test failures, ref tests in #297.
This PR pins the issue to connector's latest version so that other packages can be unblocked from version updates.
Tests hinting the issue is related to connectors (AND not session dispose)
In the first commit of PR, the session dispose is NOT commented out. This leads to failures like
RuntimeError: Session is closedin several tests during test run. Ref GCB logIn the second iteration of this PR, the session dispose is commented out ensuring sessions are not disposed/closed at all. This leads to
RuntimeError: Session is closedfailures in several tests. Ref GCB logUpdate
The errors seem like coming from an additional connector close, which is now removed in dd79dae and 599cc54