Skip to content

chore: Fix LoopConnectorError by enforcing background loop execution for Async Classes tests #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dishaprakash merged 8 commits into from
Jan 13, 2026
Merged

chore: Fix LoopConnectorError by enforcing background loop execution for Async Classes tests #182

dishaprakash merged 8 commits into from
Jan 13, 2026

Conversation

@dishaprakash
Copy link
Contributor

@dishaprakash dishaprakash commented Dec 20, 2025 •
edited
Loading

This PR:

  • Adds a run_on_background helper to test fixtures.
  • Wraps direct calls to _ainit methods in PostgresEngine and AsyncPostgresChatStore, AsyncPostgresDocumentStore, AsyncPostgresIndexStore, AsyncPostgresReader, AsyncPostgresVectorStore operations in tests to ensure they execute on the engine's background loop, matching the new strict loop enforcement.

@dishaprakash dishaprakash requested review from a team as code owners December 20, 2025 08:52
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/llama-index-cloud-sql-pg-python API. label Dec 20, 2025
@dishaprakash dishaprakash marked this pull request as draft December 23, 2025 08:52
@averikitsch averikitsch added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jan 5, 2026
@dishaprakash dishaprakash marked this pull request as ready for review January 12, 2026 09:01
@dishaprakash dishaprakash merged commit b4e9124 into main Jan 13, 2026
12 checks passed
@dishaprakash dishaprakash deleted the con-loop-fix branch January 13, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees

@averikitsch averikitsch

Labels

api: cloudsql-postgres Issues related to the googleapis/llama-index-cloud-sql-pg-python API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dishaprakash @averikitsch