feat: Support multiple columns in graph visualization #100
+90
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso, add a test for the multi-column case.
product-auto-label
bot
added
size: m
gcf-owl-bot
bot
removed
the
owlbot:run
tswast
reviewed
Mar 12, 2025
Comment on lines
+661
to
+662
| if not query_result[column].apply(_is_valid_json).all(): | ||
| return False |
There was a problem hiding this comment.
Interesting, so the widget only works if all columns are valid JSON? This will return False if there's even one column with one cell that returns false for _is_valid_json.
Please add a docstring explaining more what the expectation is for data for the widget to be supported.
There was a problem hiding this comment.
If some columns are not json, the widget actually does work - it simply ignores the non-json columns for purposes of populating the widget, but shows them in the widget's tabular view. I have a separate work in progress to handle this, but it's not included in this branch.
Is it ok to check in what we have, and do a follow-up PR to handle the "some columns not json" scenario?
tswast
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕