Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update required checks #19

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore: update required checks #19

merged 1 commit into from
Apr 12, 2024

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as an issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #12 🦕

@chelsea-lin chelsea-lin requested a review from tswast April 11, 2024 23:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Apr 11, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_presubmit branch from ba6e827 to 555257c Compare April 12, 2024 20:55
@chelsea-lin chelsea-lin marked this pull request as ready for review April 12, 2024 20:55
@chelsea-lin chelsea-lin requested review from a team as code owners April 12, 2024 20:55
tswast
tswast reviewed Apr 12, 2024
View reviewed changes
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_presubmit branch from 555257c to 8e281a9 Compare April 12, 2024 21:13
@tswast tswast merged commit 8a7cb5f into main Apr 12, 2024
15 of 18 checks passed
@tswast tswast deleted the main_chelsealin_presubmit branch April 12, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@Genesis929 Genesis929

Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: update required checks
3 participants
@chelsea-lin @tswast @Genesis929