feat: support json_[string][pyarrow] dtype and make pandas-gbq dtypes more independent from google-cloud-bigquery logic
#893
+906
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
tswast
added
do not merge
|
Marking as |
6 tasks
product-auto-label
bot
added
the
api: bigquery
tswast
commented
Mar 12, 2025
Comment on lines
+35
to
+43
| # Prefer JSON type built-in to pyarrow (adding in 19.0.0), if available. | ||
| # Otherwise, fallback to db-dtypes, where the JSONArrowType was added in 1.4.0, | ||
| # but since they might have an older db-dtypes, have string as a fallback for that. | ||
| if hasattr(pyarrow, "json_"): | ||
| json_arrow_type = pyarrow.json_(pyarrow.string()) | ||
| elif hasattr(db_dtypes, "JSONArrowType"): | ||
| json_arrow_type = db_dtypes.JSONArrowType() | ||
| else: | ||
| json_arrow_type = pyarrow.string() |
There was a problem hiding this comment.
I had a change of heart in googleapis/python-bigquery#1876 For to_arrow(), we should emulate the BQ Storage Read API as closely as possible.
For read_gbq(), that's where I'd like to use the extension type(s) if available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards internal issue 401630655 🦕