fix: compilation of a labeled custom FunctionElement when used in grouping #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
If we have a labeled custom function that we are grouping by, and the function does not support the `default` dialect, we can not compile our query.
snapiri
force-pushed
the
1150-Fix_grouped_label
branch
from
670082f to
87696fb
Compare
|
@tswast - I would appreciate any help with promoting this fix. |
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
tswast
reviewed
Jan 21, 2025
tswast
changed the title
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
tswast
approved these changes
Jan 21, 2025
|
Thanks so much for the contribution @snapiri ! |
|
This should be released as part of 1.12.1. Follow #1142 for further updates. |
|
Thank you for pushing this forward @tswast ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a labeled custom function that we are grouping by, and the function does not support the
defaultdialect, we can not compile our query.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1150 🦕