Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/compliance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
python: ['3.14']
steps:
- name: Checkout
uses: actions/checkout@v5
uses: actions/checkout@v6
- name: Setup Python
uses: actions/setup-python@v6
with:
Expand All @@ -32,7 +32,7 @@ jobs:
python: ['3.14']
steps:
- name: Checkout
uses: actions/checkout@v5
uses: actions/checkout@v6
- name: Setup Python
uses: actions/setup-python@v6
with:
Expand Down
3 changes: 2 additions & 1 deletion samples/snippets/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
pytest==8.4.2
pytest===8.3.5; python_version < '3.10'
pytest==9.0.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The upgrade to pytest==9.0.2 will break the build for older Python versions. According to the pytest 9.0.0 release notes, this version requires Python 3.10+. The samples/snippets/noxfile.py runs tests on Python 3.8 and 3.9, which are no longer supported by this version of pytest. This will cause installation and test failures for these Python versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the migration of this library to the google-cloud-python mono-repo, we will be transferring the tests examples in samples/snippets to the python-docs-samples repo. Thus this update will no longer impact those snippets.

Loading