fix(owl-bot): ignore non-cloud php repos #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this won't close existing open PRs, but should prevent new PRs from being opened (after the scan GitHub configs cron task runs) |
bshaffer
approved these changes
Feb 7, 2024
sofisl
reviewed
Feb 7, 2024
| @@ -32,6 +32,6 @@ export function shouldIgnoreRepo(ownerSlashRepo: string): boolean { | |||
| // subdirectories of google-cloud-php and never accept pull requests. | |||
| const regexp = process.env.IGNORE_REPO_REGEXP | |||
There was a problem hiding this comment.
Seems like these should always be ignored, not only if they're not explicitly specified.
There was a problem hiding this comment.
I think is an override for tests/testing environments and we use the default in production
sofisl
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
owl-bot is opening some PRs against sharded, non-php repos. We should not be opening copy-code PRs against these repos.
example: googleapis/php-shopping-merchant-reports#5
These repos
googleapis/php-<something>, are non-cloud and split of the primary PHP monorepogoogleapis/google-cloud-php.