Skip to content

chore: add checksum validation on x_emulator_crc32c and x_emulator_md5 fields #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krishnamd-jkp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add checksum validation on x_emulator_crc32c and x_emulator_md5 fields #753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc03f6a
chore: add checksum validation on x_emulator_crc32c and x_emulator_md…
krishnamd-jkp Dec 18, 2025
d3fbbbf
chore: fix formatting
krishnamd-jkp Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions gcs/object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
from google.protobuf import field_mask_pb2, json_format

import testbench
import testbench.common
from google.storage.v2 import storage_pb2

# Lock to prevent race condition while generating metadata versions:
Expand Down Expand Up @@ -115,10 +116,32 @@ def init(
cs = metadata.checksums
if len(cs.md5_hash) != 0 and actual_md5Hash != cs.md5_hash:
testbench.error.mismatch(
"md5Hash", cs.md5_hash, actual_md5Hash, context
"md5Hash", actual_md5Hash, cs.md5_hash, context
)
if cs.HasField("crc32c") and actual_crc32c != cs.crc32c:
testbench.error.mismatch("crc32c", cs.crc32c, actual_crc32c, context)
testbench.error.mismatch("crc32c", actual_crc32c, cs.crc32c, context)

# Check if checksum is present in x_emulator_crc32c field.
if (
"x_emulator_crc32c" in metadata.metadata
and len(metadata.metadata["x_emulator_crc32c"]) != 0
):
got_crc32c_encoded = metadata.metadata["x_emulator_crc32c"]
# Decode to int32.
got_crc32c = testbench.common.rest_crc32c_to_proto(got_crc32c_encoded)
if actual_crc32c != got_crc32c:
testbench.error.mismatch("crc32c", actual_crc32c, got_crc32c, context)

# Check if md5h hash is present in x_emulator_md5 field.
if (
"x_emulator_md5" in metadata.metadata
and len(metadata.metadata["x_emulator_md5"]) != 0
):
got_md5_encoded = metadata.metadata["x_emulator_md5"]
# Decode to bytes.
got_md5 = testbench.common.rest_md5_to_proto(got_md5_encoded)
if actual_md5Hash != got_md5:
testbench.error.mismatch("md5", actual_md5Hash, got_md5, context)
metadata.checksums.md5_hash = actual_md5Hash
metadata.checksums.crc32c = actual_crc32c
metadata.create_time.FromDatetime(timestamp)
Expand Down