Fix Issue #12 Android google signin crash when add AdditionalScopes i… #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionalScopes in configuration bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you call CallConfigure() on line 237 and then again on either SignIn() (L302) or SignInSilently() (L318) the value of current_configuration_->additional_scopes() (L267) seems to be gone/wrongly adjust the second time it is being read while it is actually a const char* which is odd.
This fixes the crash but I assume there is something else going wrong which causes the value of additional_scopes being adjusted. So it might require some better research to track that one down.