-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: sync skills with Discovery API #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@googleworkspace/cli": patch | ||
| --- | ||
|
|
||
| Sync generated skills with latest Google Discovery API specs |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -58,6 +58,9 @@ The authenticated user for the request is made the data owner of the new calenda | |||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||
| Note: We recommend to authenticate as the intended data owner of the calendar. You can use domain-wide delegation of authority to allow applications to act on behalf of a specific user. Don't use a service account for authentication. If you use a service account for authentication, the service account is the data owner, which can lead to unexpected behavior. | ||||||||||||||||||||||||||||||||||||||||
| - `patch` — Updates metadata for a calendar. This method supports patch semantics. | ||||||||||||||||||||||||||||||||||||||||
| - `transferOwnership` — Transfers a secondary calendar between users within a Google Workspace organization. Requires user authentication with Manage Calendars administrator privilege, and one of the following authorization scopes: | ||||||||||||||||||||||||||||||||||||||||
| - https://www.googleapis.com/auth/calendar | ||||||||||||||||||||||||||||||||||||||||
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. | ||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+61
to
+63
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The formatting for the
Suggested change
Comment on lines
+61
to
+63
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The markdown formatting for the nested list of scopes is broken. Because the nested bullet points are not indented, they are parsed as top-level list items, which breaks the list structure and disrupts the rendering of the skill description. Additionally, the final sentence is run-on with the second scope URL. Please indent the nested list items by 4 spaces and format the subsequent text as a nested paragraph. Note: Since this file is auto-generated, the generator script (
Suggested change
Comment on lines
+61
to
+63
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The description for
Suggested change
|
||||||||||||||||||||||||||||||||||||||||
| - `update` — Updates metadata for a calendar. | ||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||
| ### channels | ||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown list formatting is broken here because the authorization scopes and the subsequent description text are not indented. This breaks the markdown list structure, which can prevent LLM parsers or agents from correctly reading and understanding the available scopes and instructions for the
transferOwnershipmethod.Additionally, since these skill files are auto-generated, this indicates a bug in the generator (
generate_skills.rs) where descriptions containing newlines are not being properly sanitized or indented. The generator should be updated to strip newlines or format them with appropriate indentation (e.g., 4 spaces for sub-bullets) to preserve the markdown structure.Here is how the formatted markdown should look: