-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEPENDENCY] Update module dependencies to latest versions #3088
Conversation
Signed-off-by: Ilya Eryomenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @GLobyNew, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the module dependencies to the latest versions. The author ran go get -u ./...
and go mod tidy
to update the dependencies and address four known vulnerabilities reported by the OpenSSF Scorecard. The changes primarily involve updating the go.mod
and go.sum
files with the latest versions of the required modules.
Highlights
- Dependency Updates: The pull request updates several dependencies in the
go.mod
file, includingfilippo.io/age
,github.com/ProtonMail/go-crypto
,github.com/google/go-cmp
,github.com/noborus/ov
,github.com/urfave/cli/v2
,golang.org/x/crypto
,golang.org/x/exp
,golang.org/x/net
,golang.org/x/oauth2
,golang.org/x/sys
,golang.org/x/term
,al.essio.dev/pkg/shellescape
,github.com/klauspost/compress
,github.com/klauspost/cpuid/v2
,golang.org/x/sync
,golang.org/x/text
, andgithub.com/spf13/pflag
. - Vulnerability Fixes: The primary motivation for this pull request is to address four known vulnerabilities by updating the dependencies to their latest versions.
- go.sum Updates: The
go.sum
file is updated to reflect the changes in thego.mod
file, ensuring that the correct versions of the dependencies are used.
Changelog
Click here to see the changelog
- go.mod
- Updated
filippo.io/age
fromv1.2.1-0.20240618131852-7eedd929a6cf
tov1.2.1
(line 6). - Updated
github.com/ProtonMail/go-crypto
fromv1.1.5
tov1.1.6
(line 7). - Updated
github.com/google/go-cmp
fromv0.6.0
tov0.7.0
(line 17). - Updated
github.com/noborus/ov
fromv0.38.0
tov0.39.0
(line 32). - Updated
github.com/urfave/cli/v2
fromv2.27.5
tov2.27.6
(line 38). - Updated
golang.org/x/crypto
fromv0.33.0
tov0.36.0
(line 42). - Updated
golang.org/x/exp
fromv0.0.0-20250207012021-f9890c6ad9f3
tov0.0.0-20250305212735-054e65f0b394
(line 43). - Updated
golang.org/x/net
fromv0.34.0
tov0.37.0
(line 44). - Updated
golang.org/x/oauth2
fromv0.26.0
tov0.28.0
(line 45). - Updated
golang.org/x/sys
fromv0.30.0
tov0.31.0
(line 46). - Updated
golang.org/x/term
fromv0.29.0
tov0.30.0
(line 47). - Updated
al.essio.dev/pkg/shellescape
fromv1.5.1
tov1.6.0
(line 52). - Updated
github.com/klauspost/compress
fromv1.17.11
tov1.18.0
(line 70). - Updated
github.com/klauspost/cpuid/v2
fromv2.2.9
tov2.2.10
(line 71). - Updated
golang.org/x/sync
fromv0.11.0
tov0.12.0
(line 84). - Updated
golang.org/x/text
fromv0.22.0
tov0.23.0
(line 85).
- Updated
- go.sum
- The
go.sum
file has been updated to reflect the changes in thego.mod
file, ensuring the correct checksums for the updated dependencies.
- The
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The go mod tidy
command automatically removes unused dependencies from the go.mod
file, keeping the project lean and clean.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the dependencies of the gopass project to their latest versions. This is a good practice for maintaining the security and stability of the project. The pull request description mentions that this update fixes four known vulnerabilities, which is a significant benefit. However, it also raises the question of how often dependencies should be upgraded and what policy gopass follows regarding dependency management. Addressing this question would improve the project's long-term maintainability.
Summary of Findings
- Dependency Upgrade Frequency: The pull request description asks about the frequency of dependency upgrades and the project's policy on this matter. This is an important question that should be addressed to ensure consistent and timely updates.
- Missing Documentation: The pull request lacks documentation regarding the dependency update process and policy. Adding this documentation would help maintainers and contributors understand how to manage dependencies in the future.
Merge Readiness
The pull request updates dependencies and fixes known vulnerabilities, which is a positive step. However, the question of dependency upgrade frequency and the lack of documentation on the dependency management policy should be addressed before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Given the presence of medium severity issues, I recommend that the pull request not be merged until those are addressed.
@@ -14,7 +14,7 @@ | |||
github.com/fatih/color v1.18.0 | |||
github.com/godbus/dbus/v5 v5.1.0 | |||
github.com/gokyle/twofactor v1.0.1 | |||
github.com/google/go-cmp v0.6.0 | |||
github.com/google/go-cmp v0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -29,27 +29,27 @@ | |||
github.com/mitchellh/go-ps v1.0.0 | |||
github.com/muesli/crunchy v0.4.0 | |||
github.com/nbutton23/zxcvbn-go v0.0.0-20210217022336-fa2cb2858354 | |||
github.com/noborus/ov v0.38.0 | |||
github.com/noborus/ov v0.39.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/pquerna/otp v1.4.1-0.20241104074508-c95b6974670c | ||
github.com/schollz/closestmatch v0.0.0-20190308193919-1fbe626be92e | ||
github.com/skip2/go-qrcode v0.0.0-20200617195104-da1b6568686e | ||
github.com/stretchr/testify v1.10.0 | ||
github.com/twpayne/go-pinentry/v4 v4.0.0 | ||
github.com/urfave/cli/v2 v2.27.5 | ||
github.com/urfave/cli/v2 v2.27.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gopkg.in/yaml.v3 v3.0.1 | ||
) | ||
|
||
require ( | ||
al.essio.dev/pkg/shellescape v1.5.1 // indirect | ||
al.essio.dev/pkg/shellescape v1.6.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -67,8 +67,8 @@ | |||
github.com/jwalton/gchalk v1.3.0 // indirect | |||
github.com/jwalton/go-supportscolor v1.2.0 // indirect | |||
github.com/kjk/lzmadec v0.0.0-20210713164611-19ac3ee91a71 // indirect | |||
github.com/klauspost/compress v1.17.11 // indirect | |||
github.com/klauspost/cpuid/v2 v2.2.9 // indirect | |||
github.com/klauspost/compress v1.18.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/klauspost/compress v1.17.11 // indirect | ||
github.com/klauspost/cpuid/v2 v2.2.9 // indirect | ||
github.com/klauspost/compress v1.18.0 // indirect | ||
github.com/klauspost/cpuid/v2 v2.2.10 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/ulikunitz/xz v0.5.12 // indirect | ||
github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 // indirect | ||
golang.org/x/sync v0.11.0 // indirect | ||
golang.org/x/text v0.22.0 // indirect | ||
golang.org/x/sync v0.12.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golang.org/x/sync v0.11.0 // indirect | ||
golang.org/x/text v0.22.0 // indirect | ||
golang.org/x/sync v0.12.0 // indirect | ||
golang.org/x/text v0.23.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ilya Eryomenko <[email protected]>
Oh, I see other pull requests in which age should not be upgraded and deps bot helps with dependencies already. But I still wonder which packages could be upgraded, depbot really selective about what should be upgraded or not. |
@GLobyNew Thank you. But you don't need to bother, we have automation to update dependencies during releases. It's ok to pull in updates outside of releases, but that's only best effort. |
I don't know if its okay to do. But I looked up the "OpenSSF Scorecard report" of this project: https://securityscorecards.dev/viewer/?uri=github.com/gopasspw/gopass
And was surprised to see, that gopass is affected to 4 known vulnerabilities.
Turns out they all can be fixed by just upgrading all modules using two commands:
So basically after this merge all four vulnerabilities will be fixed and I wonder how often should deps be upgraded? Or every project has it's own policy about it?
And what policy does gopass follow?
Thanks!