This repository was archived by the owner on Nov 15, 2017. It is now read-only.
Suggested change to the flow of settings.html#57
Closed
GuardianMajor wants to merge 1 commit intogorhill:masterfrom
GuardianMajor:patch-2
Closed
Suggested change to the flow of settings.html#57GuardianMajor wants to merge 1 commit intogorhill:masterfrom GuardianMajor:patch-2
GuardianMajor wants to merge 1 commit intogorhill:masterfrom
GuardianMajor:patch-2
Conversation
I told you I will mock up what I think would be a less busy interface, hope you like it.
Owner
|
Thank you very much, this will be part of the next version. I just imported manually the changes because I had to edit stuff and I already had committed stuff also. Javascript cannot be inlined in an extension, there has to be a clear separation between html and js (which is good imo), and also I use jquery so I could simplify by also reworking the css (margin, padding, alignment etc.) I kept the look though, it's neat. |
Owner
|
Manually imported, in v0.5.6 |
Author
|
You are welcome my dear friend, glad it could help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I told you I will mock up what I think would be a less busy interface, hope you like it.