Skip to content

Propagate shadow expiry from user templates to created user objects.#22

Open
sunweaver wants to merge 1 commit intogosa-project:masterfrom
sunweaver:pr/shadowexpire-propagation-from-usertemplate
Open

Propagate shadow expiry from user templates to created user objects.#22
sunweaver wants to merge 1 commit intogosa-project:masterfrom
sunweaver:pr/shadowexpire-propagation-from-usertemplate

Conversation

@sunweaver
Copy link
Copy Markdown
Contributor

No description provided.

@master-caster
Copy link
Copy Markdown
Contributor

The following code seems to do the same with the exception
that it will only show the checkbox if shadowExpire is in the future.

    /* Only enable checkbox, if shadowExpire is in the future */
    if($this->shadowExpire > time()) {
      $this->activate_shadowExpire= "1";
    }

With this PR

$this->activate_shadowExpire= "1";

gets always executed if shadowExpire isn't 0.
Do we need the code that follows if we don't care about the value in shadowExpire?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants