addons/schoolmanager/class_importaccounts.inc: With every accountStat…#73
Open
sunweaver wants to merge 1 commit intogosa-project:masterfrom
Open
addons/schoolmanager/class_importaccounts.inc: With every accountStat…#73sunweaver wants to merge 1 commit intogosa-project:masterfrom
sunweaver wants to merge 1 commit intogosa-project:masterfrom
Conversation
…usCheck() run the groupStatusCheck(). This assures that always all _group_actions and _ogroup_actions are properly defined/set.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds groupStatusCheck() calls to ensure group status is checked consistently alongside account status checks across multiple import phases. The changes ensure that group-related data structures are properly populated and synchronized whenever account status is verified.
- Adds
groupStatusCheck()calls in phases 3, 4, and 5 where they were previously missing - Maintains consistency with existing pattern where both checks run together (already present in phases 7 and 8)
- Ensures group status data is available for display alongside account data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Needs rebase, otherwise LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…usCheck() run the groupStatusCheck().
This assures that always all _group_actions and _ogroup_actions are properly defined/set.