Skip to content

Fix/users and groups adding #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lennardrischen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/users and groups adding #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d6bd4a
Fix dynamic property deprecations
Nov 13, 2025
9c44612
Fix users and groups addding from list
Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions admin/sudo/class_sudoGeneric.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ class sudo extends plugin
protected $description= "";

protected $sudoUser = array("ALL");
protected $sudoUserList;
protected $sudoCommand= array();
protected $sudoCommandList;
protected $sudoHost = array("ALL");
protected $sudoHostList;
protected $sudoRunAs = array("ALL");
protected $sudoRunAsList;

private $is_default = FALSE;

Expand All @@ -45,6 +49,7 @@ class sudo extends plugin

public $orig_dn;
private $systemEnabled = FALSE;
public trustModeDialog $trustModeDialog;

/*! \brief Returns to the base department for sudo roles.
This department is then used to store new roles.
Expand Down Expand Up @@ -158,9 +163,14 @@ class sudo extends plugin
}

/* Add selected hosts to the sudoUser list */
if(isset($_POST['userGroupSelect_save']) || isset($_POST['ok-save']) && $this->dialog instanceof userGroupSelect){
if($this->acl_is_writeable("sudoUser")){
foreach($this->dialog->save() as $entry){
if (isset($_POST['add_users_finish']) || isset($_POST['userGroupSelect_save']) || isset($_POST['ok-save']) && $this->dialog instanceof userGroupSelect) {
$users = $this->dialog->detectPostActions();
if (isset($users['targets'])) {
$headpage = $this->dialog->getHeadpage();

foreach ($users['targets'] as $dn) {
$entry = $headpage->getEntry($dn);

if(in_array_strict("posixGroup",$entry['objectClass'])){
$name = trim("%".$entry['cn'][0]);
}elseif(isset($entry['uid'][0])){
Expand Down