Skip to content

fix: remove unused runtime/cgo import that broke non-CGo builds #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tooolbox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove unused runtime/cgo import that broke non-CGo builds #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions scripting/internal/url/url.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package url

import (
"fmt"
"runtime/cgo"

"github.com/gost-dom/browser/html"
"github.com/gost-dom/browser/internal/constants"
Expand All @@ -18,10 +17,6 @@ func NewURL[T any](host js.ScriptEngine[T]) URL[T] {
return URL[T]{}
}

type handleDisposable cgo.Handle

func (h handleDisposable) Dispose() { cgo.Handle(h).Delete() }

func CreateURL[T any](
cbCtx js.CallbackContext[T],
u string,
Expand Down