fead: add sequence if group id does not have it (#73)

* feat: add sequence if group id does not have it"

* refactor: use fmt package

* fix: lint issue

Author: ishanarya0

modules/firehose/driver_plan.go

@@ -17,8 +17,7 @@ import (
 const SourceKafkaConsumerAutoOffsetReset = "SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET"
 
 var (
-	suffixRegex      = regexp.MustCompile(`^([A-Za-z0-9-]+)-([0-9]+)$`)
-	errGroupIDFormat = fmt.Errorf("group id must match the format '%s'", suffixRegex)
+	suffixRegex = regexp.MustCompile(`^([A-Za-z0-9-]+)-([0-9]+)$`)
 )
 
 func (fd *firehoseDriver) Plan(_ context.Context, exr module.ExpandedResource, act module.ActionRequest) (*resource.Resource, error) {
@@ -212,7 +211,7 @@ func (fd *firehoseDriver) planReset(exr module.ExpandedResource, act module.Acti
 func getNewConsumerGroupID(curGroup string) (string, error) {
 	matches := suffixRegex.FindStringSubmatch(curGroup)
 	if expLen := 3; len(matches) != expLen {
-		return "", errGroupIDFormat
+		return fmt.Sprintf("%s-1", curGroup), nil
 	}
 	prefix, sequence := matches[1], matches[2]
 

modules/firehose/driver_plan_test.go

@@ -573,8 +573,8 @@ func TestGetNewConsumerGroupID(t *testing.T) {
 		{
 			title:           "invalid-group-id",
 			consumerGroupID: "test-firehose-xyz",
-			want:            "",
-			wantErr:         errGroupIDFormat,
+			want:            "test-firehose-xyz-1",
+			wantErr:         nil,
 		},
 		{
 			title:           "valid-group-id",