enhance: provide contexts to credential helpers when listing credentials #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
previously approved these changes
Jun 12, 2025
njhale
previously approved these changes
Jun 12, 2025
|
Re-requesting review because I added a test. |
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
credentials-refactor
branch
from
9b2f066 to
300bc5f
Compare
g-linville
commented
Jun 13, 2025
| @@ -53,7 +53,7 @@ init-docs: | |||
|
|
|||
| # Ensure docs build without errors. Makes sure generated docs are in-sync with CLI. | |||
| validate-docs: gen-docs | |||
| docker run --rm --workdir=/docs -v $${PWD}/docs:/docs node:18-buster yarn build | |||
| docker run --rm --workdir=/docs -v $${PWD}/docs:/docs node:18-buster npm run build | |||
There was a problem hiding this comment.
I did this for consistency with the other change from yarn to npm in the init-docs target. Plus it wasn't working with Node v18 and yarn.
njhale
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for obot-platform/obot#3180
This PR changes the way we request a list of credentials by also including the contexts as input. The contexts are ignored by all non-database credential helpers (like Wincred and macOS Keychain), so we still filter by context after we call
GetAll, but this allows the database credential helpers to be more efficient and only return to us the credentials that we actually need.Once this PR is merged, I will have a PR for Obot to bump the GPTScript dependency. We might have to temporarily (or permanently, as I don't think it will do any harm) enable schema migration for the credentials table, which is currently disabled with an environment variable.
Related PR to change the credential helpers: obot-platform/tools#692