Skip to content

#fix: allocator for tristate_optional usage #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

#fix: allocator for tristate_optional usage #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions packages/ferry_generator/lib/graphql_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class GraphqlBuilder implements Builder {
outputAssetId(_schemaId!, schemaExtension, config.outputDir);

final schemaUrl = schemaOutputAsset.uri.toString();
final schemaAllocator = GqlAllocator(
final allocator = GqlAllocator(
buildStep.inputId.uri.toString(),
config.sourceExtension,
outputAssetId(buildStep.inputId, schemaExtension, config.outputDir)
Expand All @@ -95,8 +95,6 @@ class GraphqlBuilder implements Builder {
config.outputDir,
);

final varAllocator = schemaAllocator;

final dataToVarsMode = config.dataToJsonMode;

final libs = <String, Library>{
Expand All @@ -114,7 +112,7 @@ class GraphqlBuilder implements Builder {
addTypenames(schema),
p.basename(generatedFilePath(buildStep.inputId, varExtension)),
config.typeOverrides,
varAllocator,
allocator,
triStateValueConfig,
config.shouldGenerateVarsCreateFactories),
reqExtension: buildReqLibrary(
Expand All @@ -128,25 +126,20 @@ class GraphqlBuilder implements Builder {
config.typeOverrides,
config.enumFallbackConfig,
generatePossibleTypesMap: config.shouldGeneratePossibleTypes,
allocator: schemaAllocator,
allocator: allocator,
triStateValueConfig: triStateValueConfig),
};

for (var entry in libs.entries) {
final generatedAsset =
outputAssetId(buildStep.inputId, entry.key, config.outputDir);
final schemaOutputAsset =
outputAssetId(_schemaId, schemaExtension, config.outputDir);

final allocator = GqlAllocator(
buildStep.inputId.uri.toString(),
config.sourceExtension,
generatedAsset.uri.toString(),
schemaOutputAsset.uri.toString(),
config.outputDir,
);

await writeDocument(generatedAsset, entry.value, allocator, buildStep);
await writeDocument(
generatedAsset,
entry.value,
allocator,
buildStep,
);
}
}
}