fix(gql_websocket_link): Fix race condition causing exception and double complete #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I just merged #466, which now causes a merge conflict. Can you take a look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition in the
subscribefunction of the _Client class. If the dispose function returned by thesubscribemethod is called which calls thereleaser()method, and then aCompleteMessageis received on the websocket while thereleaser()is awaiting to compose its ownCompleteMessage, thenreleaser()is called twice and the request is double released causing an exception. I've added a flag to avoid a double release.The second patch simply avoids the situation where a websocket is already closed when an error occurs, causing an already completed exception when
completeError()is called on the completer.