Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate top-level service selection #1768

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Deprecate top-level service selection #1768

wants to merge 3 commits into from

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Mar 26, 2025

This PR removes top-level service selection from the docs and marks the fields as deprecated.
Beyla still would be able to be configured that we want to keep deprecated/undocumented.

Fixes #1684
Fixes #1206

@marctc marctc requested review from grafsean and a team as code owners March 26, 2025 14:55
@grafsean
Copy link
Contributor

Thanks @marctc and does this need to be back ported to 2.0 or is this for a future release?

@marctc
Copy link
Contributor Author

marctc commented Mar 26, 2025

Thanks @marctc and does this need to be back ported to 2.0 or is this for a future release?

I think this probably good for Beyla 2.1. I don't think we should backport it

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.25%. Comparing base (cf94133) to head (bc7cff2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
- Coverage   67.00%   65.25%   -1.76%     
==========================================
  Files         219      203      -16     
  Lines       22691    20890    -1801     
==========================================
- Hits        15205    13631    -1574     
+ Misses       6714     6378     -336     
- Partials      772      881     +109     
Flag Coverage Δ
integration-test 54.52% <ø> (-0.32%) ⬇️
k8s-integration-test 53.03% <ø> (+<0.01%) ⬆️
oats-test 34.32% <ø> (+0.02%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate top-level service selection open_port option interferences with kubernetes discovery.
3 participants