ServiceSelection: add support for aggregated metric #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0/patterns-runtime-resource-call
…0/patterns-runtime-resource-call
…0/patterns-runtime-resource-call
…e detected_labels
This reverts commit a4fcc32.
…1/aggregated-metric
There was a problem hiding this comment.
looking good! curious what the labels call is for now that we've gone back to the regular /volume call using service_name=~".+"? I'm fine leaving the resource type and logic to run a labels query (as we need it for __stream_shard__ and I'm sure for other things in the future), but I don't think we need to add the state to the ServiceSelection scene unless I'm missing something?
| const aggregatedMetricsEnabled: boolean | undefined = config.featureToggles.exploreLogsAggregatedMetrics; | ||
| // Don't export AGGREGATED_SERVICE_NAME, we want to rename things so the rest of the application is agnostic to how we got the services | ||
| const AGGREGATED_SERVICE_NAME = '__aggregated_metric__'; | ||
| const AGGREGATED_METRIC_START_DATE = dateTime('2024-08-30', 'YYYY-MM-DD'); |
There was a problem hiding this comment.
eventually we may want this to be configurable (ie. OSS users), but I'm totally fine with this for now
There was a problem hiding this comment.
Agreed, @svennergr is there a way we can configure this in deployment tools with an env variable or something so OSS users can set their own date?
svennergr
reviewed
Sep 18, 2024
…1/aggregated-metric
Co-authored-by: Sven Grossmann <[email protected]>
matyax
reviewed
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #711
Provides experimental support for aggregated metrics within explore logs with the
exploreLogsAggregatedMetricsfeature flag in Grafana.Aggregated metrics trade off resolution for much more performant queries.
Using the gdev-loki docker image in this repo:
Using the Grafana dev cluster on a 5 minute query (sum of duration of top 8 queries in service selection):
For a 12hr query (sum of duration of top 2 queries in service selection, each broken up into 6 2hr chunks):
Here's it in action on a 24hr query:
https://github.com/user-attachments/assets/a3e24f6e-268a-45ea-aa91-2e805d95f0ab
Notes for reviewer: