Filters: add support for filters with multiple values #718
Conversation
|
I did this all with fields, but didn't check labels. Looking now 🧐 |
|
Added support for labels too. |
matyax
changed the title
|
This works, but the value breakdown UIs don't support including multiple yet. |
|
Oh absolutely. But you can get there by starting with exclusions. |
|
It's a good way to keep the size of the PR down. I'm fine with merging this as is and following up in the UI (which I think will be a bigger PR) |
|
Agree. If you would like to follow that up, since you recently refactored it, go for it. Otherwise I'll follow this up. Thanks! |
|
Might be nice to use a multi select variable instead of taking up all this space for variables? Can you create 2 two follow up issues (you can assign the changing of the queries in the breakdowns to allow for multiple includes) so we don't lose track over the weekend? |
Aimed to fix #691 , this PR adds support for all fields and labels with multiple values.
Fields demo:
Demo.mov
Labels demo:
Demo.mov