Levels variable: populate values #735
Conversation
| @@ -220,7 +249,6 @@ function getVariableSet(initialDatasourceUid: string, initialFilters?: AdHocVari | |||
| applyMode: 'manual', | |||
| layout: 'vertical', | |||
| getTagKeysProvider: () => Promise.resolve({ replace: true, values: [] }), | |||
| getTagValuesProvider: () => Promise.resolve({ replace: true, values: [] }), | |||
There was a problem hiding this comment.
OHHHHHH. I'm am very certain that it would have been way easier to spot if this wasn't called "tags".
|
I added a level filter from Logs Volume and I'm not getting values: 
|
| @@ -16,8 +16,8 @@ export const VAR_FIELDS = 'fields'; | |||
| export const VAR_FIELDS_EXPR = '${fields}'; | |||
| export const VAR_PATTERNS = 'patterns'; | |||
| export const VAR_PATTERNS_EXPR = '${patterns}'; | |||
| export const VAR_LEVELS = 'levels'; | |||
There was a problem hiding this comment.
We support levels plural, what was the reason behind this change?
There was a problem hiding this comment.
because the actual name of the label is level, when calling label/level/values
There was a problem hiding this comment.
We could revert the change and hardcode the 'level' string in the getTagValuesProvider though
I can't seem to repro, does that service have any label values? |
|
I can repro in loki-dev, gdev was throwing me off because it has an indexed label called I guess we could fallback to parse the logs query, but that's kinda hacky? |
|
Well that sucks, I guess we need a way to get structured metadata values from loki before we can do this. Closing out, I'll add the e2e fix to another branch. |
Populate the values of the levels variable!