Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator: add new service with mix of json and logfmt #749

Merged
merged 3 commits into from
Sep 10, 2024
Merged

generator: add new service with mix of json and logfmt #749

merged 3 commits into from
Sep 10, 2024

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Sep 5, 2024 •
edited
Loading

Adding more test cases for e2e tests and local testing.

  • New service (nginx-json-mixed) with mix of JSON and logfmt
  • 50% of errors (2.5% of all log lines) will log an additional line containing:
    • Stacktrace with newlines
    • field that conflicts with stream selector
    • Common field in logfmt line and json lines

@gtk-grafana gtk-grafana marked this pull request as ready for review September 10, 2024 12:50
@gtk-grafana gtk-grafana requested a review from a team as a code owner September 10, 2024 12:50
@gtk-grafana gtk-grafana merged commit 2862f81 into main Sep 10, 2024
5 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/json-logfmt-mixed-generator-service branch September 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtk-grafana @matyax