Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run augurs computation in worker thread #750

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sd2k
Copy link

@sd2k sd2k commented Sep 6, 2024

This is mostly a PoC PR demonstrating how we might do this, in case it comes up in future. I've used workerize-loader to simplify the creation of the worker but we could probably do it by hand to avoid the dependency if we wanted.

Edit: actually I just profiled this and it results in a considerable amount less jank for the 'most relevant' sorting. Here are two profiles where I switch to the Most Relevant sorting, before and after this change; note that in the second one, all of the expensive work is run in the DOM worker, and there's a lot less jank reported.

I think this needs a bunch of double-checking before merging because I may have missed something (e.g. does changing the publicPath to be absolute matter? ).

This is mostly a PoC PR demonstrating how we might do this,
in case it comes up in future. I've used workerize-loader
to simplify the creation of the worker but we could probably
do it by hand to avoid the dependency if we wanted.
@sd2k sd2k requested a review from a team as a code owner September 6, 2024 14:55
@matyax
Copy link
Contributor

matyax commented Sep 10, 2024

Thank you Ben! We'll be looking at it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants