Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fall back to mixed parser if the field is missing parser in url parameter #788

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

gtk-grafana
Copy link
Contributor

Fixes: #787

To repro: either add &page_attr_var_fields=user_id|=|123 to the end of an explore logs url, or create a url on a version of explore logs from before containing fields from before #736 was merged (e.g. 0.1.3)

@gtk-grafana gtk-grafana marked this pull request as ready for review September 19, 2024 15:17
@gtk-grafana gtk-grafana requested a review from a team as a code owner September 19, 2024 15:17
return {
value: filter.value,
parser: 'mixed',
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

@matyax matyax merged commit 12a0c68 into main Sep 19, 2024
4 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/issues/787/old-field-urls-runtime-error branch September 19, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields: Runtime error when parsing urls created before 0.1.4
2 participants