make backend as default parser #1140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesoreyeram
commented
Feb 5, 2025
| @@ -660,16 +660,6 @@ func TestInlineSources(t *testing.T) { | |||
| skipGoldenCheck bool | |||
| test func(t *testing.T, frame *data.Frame) | |||
| }{ | |||
| { | |||
There was a problem hiding this comment.
This test is now removed. ( incorrect test )
yesoreyeram
commented
Feb 5, 2025
| @@ -194,6 +194,12 @@ func ApplyDefaultsToQuery(ctx context.Context, query Query, settings InfinitySet | |||
| query.Source = "url" | |||
| } | |||
| } | |||
| // if the parser is already set, we should respect that | |||
There was a problem hiding this comment.
main change in backend
yesoreyeram
commented
Feb 5, 2025
| @@ -13,6 +14,7 @@ import type { InfinityQuery } from './types'; | |||
| */ | |||
| export const migrateQuery = (query: InfinityQuery): InfinityQuery => { | |||
| let newQuery: InfinityQuery = { ...query }; | |||
| newQuery = setDefaultParserToBackend(newQuery); | |||
There was a problem hiding this comment.
main change in frontend
yesoreyeram
commented
Feb 5, 2025
| @@ -28,128 +28,6 @@ | |||
| "links": [], | |||
| "liveNow": true, | |||
| "panels": [ | |||
| { | |||
There was a problem hiding this comment.
cleanup. Not related to the PR.
ivanahuckova
approved these changes
Feb 6, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grafana/oss-big-tent-squad/issues/32
Background
Currently when a new infinity query is added to the dashboard / explore page, the parser option is set to
default/simple/frontend parser. This default parser is frontend parser. With this option, user will not be able to setup alerts, recorded queries, public dashboards or any other backend features. Since this is the default parser, users find it more annoying to migrate to backend parser at later stage to make it compatible with backend features.This PR sets the backend parser as the default parser when adding a new query to the dashboard / explore page.
How to test
Before changes
git checkout main && yarn && yarn build && mage -v && docker compose upAfter changes
git checkout default-backend-parser && yarn && yarn build && mage -v && docker compose upMigrating existing queries
Not only the new queries, this PR also migrates existing queries to use backend parser as default.
Testing existing queries
git checkout default-backend-parser && yarn && yarn build && mage -v && docker compose up