[tempo-distributed] Fix args for tempo-query in tempo-distributed helm chart #3560
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JoaoXu <[email protected]>
JoaoXu
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
|
This lgtm, but you will need to fix the issue title and perhaps some other things satisfy CI. |
JoaoXu
changed the title
Signed-off-by: JoaoXu <[email protected]>
Signed-off-by: JoaoXu <[email protected]>
JoaoXu
force-pushed
the
tempo-distributed-tempo-query-args
branch
from
b9ecbe1 to
8053866
Compare
|
@joe-elliott Hello, I've fixed the CI issues. Can I get a review on this, thanks 👍🏻 |
|
Could you please add this fix to the tempo chart as well? |
Signed-off-by: JoaoXu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix args for tempo-query container since it gives error:
flag provided but not defined: -query.base-path Usage of /tempo-query: -config string A path to the plugin's configuration file