Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Rename overrides section #3563

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Feb 7, 2025

** BREAKING **

Rename:
global_overrides => overrides
overrides => per_tenant_overrides

And clarified a few things for overrides section

Signed-off-by: Jennie Pham <[email protected]>

Signed-off-by: Jennie Pham <[email protected]>
Signed-off-by: Jennie Pham <[email protected]>
@joe-elliott
Copy link
Member

joe-elliott commented Feb 10, 2025

We need to call this out in the readme. Something like this:

https://github.com/grafana/helm-charts/blob/main/charts/tempo/README.md.gotmpl#L43-L46

I'd include some details about why we're doing it and how it better aligns with the actual config.

cc @knylander-grafana i don't know how many docs this impacts

@knylander-grafana
Copy link

knylander-grafana commented Feb 10, 2025

We need to call this out in the readme. Something like this:

main/charts/tempo/README.md.gotmpl#L43-L46

I'd include some details about why we're doing it and how it better aligns with the actual config.

cc @knylander-grafana i don't know how many docs this impacts

This mostly impacts the tempo-distributed get started doc at tempo\docs\sources\helm-charts\get-started. We should also check the overrides docs. We'll need to revisit this section: https://github.com/grafana/tempo/blob/main/docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md#optional-use-global-or-per-tenant-overrides

Copy link

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc updates look good. Thank you!

Signed-off-by: Jennie Pham <[email protected]>
Signed-off-by: Jennie Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants