-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] Rename overrides section #3563
base: main
Are you sure you want to change the base?
Conversation
1c8106a
to
f82201b
Compare
Signed-off-by: Jennie Pham <[email protected]> Signed-off-by: Jennie Pham <[email protected]>
Signed-off-by: Jennie Pham <[email protected]>
f82201b
to
0d62b00
Compare
We need to call this out in the readme. Something like this: https://github.com/grafana/helm-charts/blob/main/charts/tempo/README.md.gotmpl#L43-L46 I'd include some details about why we're doing it and how it better aligns with the actual config. cc @knylander-grafana i don't know how many docs this impacts |
This mostly impacts the tempo-distributed get started doc at tempo\docs\sources\helm-charts\get-started. We should also check the overrides docs. We'll need to revisit this section: https://github.com/grafana/tempo/blob/main/docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md#optional-use-global-or-per-tenant-overrides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc updates look good. Thank you!
Signed-off-by: Jennie Pham <[email protected]>
Signed-off-by: Jennie Pham <[email protected]>
** BREAKING **
Rename:
global_overrides
=>overrides
overrides
=>per_tenant_overrides
And clarified a few things for overrides section