Combine all initializer commands with && to catch any failing commands #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frittentheke
force-pushed
the
failInitOnNonZero_435
branch
from
33d10ee
to
24e2177
Compare
By running two commands instead of one (the second being the cat | grep), any failures (non-zero exit code) of the first part (containing `k6 inspect`) will be lost and masked away. By chaining them all with `&&` the first non-zero RC will fail the whole command and return. Fixes: grafana#435
frittentheke
force-pushed
the
failInitOnNonZero_435
branch
from
24e2177
to
a054bf7
Compare
|
@frittentheke, thank you for the PR! It seems like you have opened 2 PRs for the same issue? Could you please leave only one? Quickly skimming the code, the change seems reasonable on the first glance, but I need to look up the details there again. Additionally, this change requires testing. I'll be able to fully review this in a couple of weeks approx. Hope that's alright! |
I changed one to draft and shall remove the "fixes" reference to this issue. It is simply not "just" a bugfix. Thanks for looking into and testing #453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By running two commands instead of one (the second being the cat | grep), any failures (non-zero exit code) of the first part (containing
k6 inspect) will be lost and masked away.By chaining them all with
&&the first non-zero RC will fail the whole command and return.Fixes: #435