Add support for windows (#41)

* don't run pruner in windows
* set k6binary name according to os
* test in windows
* close always binary after download
* document pruner is not enabled in Windows

---------

Signed-off-by: Pablo Chacin <[email protected]>

.github/workflows/test.yml

@@ -20,6 +20,7 @@ jobs:
         platform:
           - ubuntu-latest
           - macos-latest
+          - windows-latest
     runs-on: ${{matrix.platform}}
     steps:
       - name: Install Go

k6binary.go

@@ -0,0 +1,6 @@
+//go:build !windows
+// +build !windows
+
+package k6provider
+
+const k6Binary = "k6"

k6binary_windows.go

@@ -0,0 +1,6 @@
+//go:build windows
+// +build windows
+
+package k6provider
+
+const k6Binary = "k6.exe"

lock.go

@@ -1,3 +1,6 @@
+//go:build !windows
+// +build !windows
+
 package k6provider
 
 import (

lock_test.go

@@ -1,3 +1,6 @@
+//go:build !windows
+// +build !windows
+
 package k6provider
 
 import (

provider.go

@@ -20,7 +20,6 @@ import (
 )
 
 const (
-	k6Binary             = "k6"
 	k6Module             = "k6"
 	defaultPruneInterval = time.Hour
 )
@@ -126,7 +125,10 @@ type Config struct {
 	BuildServiceAuth string
 	// BuildServiceHeaders HTTP headers for the k6 build service
 	BuildServiceHeaders map[string]string
-	// HighWaterMark is the upper limit of cache size to trigger a prune
+	// HighWaterMark is the upper limit of cache size to trigger a prune.
+	// If 0 (default) the cache is not pruned.
+	// This option is ignored when running in windows systems
+	// See https://github.com/grafana/k6provider/issues/42
 	HighWaterMark int64
 	// PruneInterval minimum time between prune attempts. Defaults to 1h
 	PruneInterval time.Duration
@@ -324,13 +326,12 @@ func (p *Provider) GetBinary(
 	}
 
 	err = p.downloader.download(ctx, artifact.URL, target)
+	_ = target.Close()
 	if err != nil {
 		_ = os.RemoveAll(artifactDir)
 		return K6Binary{}, NewWrappedError(ErrDownload, err)
 	}
 
-	_ = target.Close()
-
 	// start pruning in background
 	// TODO: handle case the calling process is cancelled
 	go p.pruner.Prune() //nolint:errcheck

pruner.go

@@ -1,3 +1,6 @@
+//go:build !windows
+// +build !windows
+
 package k6provider
 
 import (

pruner_test.go

@@ -1,3 +1,6 @@
+//go:build !windows
+// +build !windows
+
 package k6provider
 
 import (

prunner_windows.go

@@ -0,0 +1,26 @@
+//go:build windows
+// +build windows
+
+package k6provider
+
+import (
+	"time"
+)
+
+// Fake implementation for windows
+type Pruner struct{}
+
+// NewPruner creates a [] given its high-water-mark limit, and the
+// prune interval
+func NewPruner(dir string, hwm int64, pruneInterval time.Duration) *Pruner {
+	return &Pruner{}
+}
+
+// Touch update access time because reading the file not always updates it
+func (p *Pruner) Touch(binPath string) {
+}
+
+// Prune the cache of least recently used files
+func (p *Pruner) Prune() error {
+	return nil
+}