Skip to content

Remove unnecessary warnings coming from kubeclient #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary warnings coming from kubeclient #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ import (
"gopkg.in/yaml.v2"
"k8s.io/client-go/informers"
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/rest"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/clientcmd"
"k8s.io/client-go/tools/clientcmd/api"

"github.com/grafana/kubernetes-diff-logger/pkg/differ"
"github.com/grafana/kubernetes-diff-logger/pkg/signals"
Expand Down Expand Up @@ -44,7 +46,7 @@ func main() {
flag.Parse()

// build k8s client
config, err := clientcmd.BuildConfigFromFlags(masterURL, kubeconfig)
config, err := buildConfigFromFlags(masterURL, kubeconfig)
if err != nil {
log.Fatalf("Error building kubeconfig: %s", err.Error())
}
Expand Down Expand Up @@ -121,3 +123,21 @@ func loadConfig(filename string, cfg *Config) error {

return yaml.UnmarshalStrict(buf, &cfg)
}

// buildConfigFromFlags is a helper function that builds configs from a master
// url or a kubeconfig filepath. These are passed in as command line flags for cluster
// components. Warnings should reflect this usage. If neither masterUrl nor kubeconfigPath
// are passed in we fall back to inClusterConfig. If inClusterConfig fails, we fall back
// to the default config.
func buildConfigFromFlags(masterUrl, kubeconfigPath string) (*rest.Config, error) {
if kubeconfigPath == "" && masterUrl == "" {
kubeconfig, err := rest.InClusterConfig()
if err == nil {
return kubeconfig, nil
}
log.Printf("error creating inClusterConfig, falling back to default config: %s", err)
}
return clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
&clientcmd.ClientConfigLoadingRules{ExplicitPath: kubeconfigPath},
&clientcmd.ConfigOverrides{ClusterInfo: api.Cluster{Server: masterUrl}}).ClientConfig()
}