feat(otlp): Allow conversion of OTel explicit bucket histograms into NHCB #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview available: https://deploy-preview-mimir-11077-zb444pucvq-vp.a.run.app/docs/mimir/latest/ |
carrieedwards
force-pushed
the
cedwards/otel-convert-hists-to-nhcb
branch
from
a96fdf2 to
2c39903
Compare
krajorama
reviewed
Apr 2, 2025
There was a problem hiding this comment.
Looks great! I think it's time we added an integration test next to otlp_ingestion_test.go that checks conversion of explicit and exponential otlp histograms to classic/nhcb and native histograms. So I'm thinking of sending a JSON that has an explicit and an exponential histogram and the two test variants differ in the setting of the new config param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the ability to optionally translation OTel explicit bucket histograms into native histograms with custom buckets, using the flag added in prometheus/prometheus#15850.
Which issue(s) this PR fixes or relates to
Fixes #
Related to prometheus/prometheus#13485.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.