-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support exclude_alerts parameter in Prometheus list rules endpoint #9300
Support exclude_alerts parameter in Prometheus list rules endpoint #9300
Conversation
f3d47ca
to
9dbcdf4
Compare
c2ec600
to
a1b5059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits, looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Co-authored-by: Taylor C <[email protected]>
…ov/prometheus-api-exclude-alerts
…thub.com:grafana/mimir into alexander-akhmetov/prometheus-api-exclude-alerts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just a nit in the Changelog.
Co-authored-by: Steve Simpson <[email protected]>
What this PR does
Adds
exclude_alerts
GET parameter to the Prometheus rules API endpoint, same as in Prometheus (documentation).It also passes the parameter further to other replicas in the gRPC call.
Example
Without
exclude_alerts
exclude_alerts=true
Which issue(s) this PR fixes or relates to
Fixes https://github.com/grafana/alerting-squad/issues/912
Part of https://github.com/grafana/alerting-squad/issues/871
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.