Chore: fix deprecation issues #1063
Open
+67
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1kman
approved these changes
Feb 14, 2025
| font-weight: 500; | ||
| min-height: ${theme.spacing(3)}; | ||
| line-height: 1.21em; // To make wrapped text look nice | ||
|
|
||
| &::after { | ||
| display: 'block' : 'none'; | ||
| display: 'block'; |
There was a problem hiding this comment.
Suggested change
| display: 'block'; | |
| display: block; |
There was a problem hiding this comment.
On line 142: display: 'none' => display: none;
There was a problem hiding this comment.
On line 152: background-image: gray; => background-color: gray;
| @@ -172,5 +172,6 @@ const getStyles = (theme: GrafanaTheme2) => ({ | |||
| }); | |||
|
|
|||
| function isMac() { | |||
| // eslint-disable-next-line deprecation/deprecation -- doesn't seem to be a stable alternative yet | |||
There was a problem hiding this comment.
One alternative is to listen to both keys.
"Hold ctrl/cmd to ..."
OR use kbar (used int grafana/grafana). Psst! kbar uses navigator.platform to detect Mac 😅
Either way, I'd modify the code so that navigator.platform can be undefined without the app exploding. With the simplest way being a try-catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A few places in the app are using deprecated methods and functions.
Solution
Update the deprecated methods and remove the unused ones.