fix: In grpc test runs we don't have the expected http metrics #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The-9880
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Seems fair in the context of gRPC checks. Agree that grafana/synthetic-monitoring-agent#942 needs to be addressed as a follow-up.
nadiamoe
requested changes
Feb 5, 2025
There was a problem hiding this comment.
I would hold this until #34 is merged, which should fix this issue.
Normally I'd be okay just merging the quick fix first, but as we're stuck with xk6-sm v0.3.0 until that one is fixed, I don't think this can realistically get to prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not convinced this fix is complete but it does stop grpc checks from panicing.
Essentially we made some assumptions about what metrics would be available but they are not for grpc only checks.
I opened a related bug because I think there is more work to be done here but this might be a reasonable minimum first step.