Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate entire website to Deno tooling #1145

Merged
merged 14 commits into from
Nov 5, 2024
Merged

Migrate entire website to Deno tooling #1145

merged 14 commits into from
Nov 5, 2024

Conversation

KnorpelSenf
Copy link
Member

This is an experiment. It removes all Node tooling from the website and uses the Deno 2 compat layer to run everything with Deno.

Copy link

github-actions bot commented Nov 5, 2024

@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 00:05 Inactive
@KnorpelSenf
Copy link
Member Author

It feels much faster to open a dev version in the browser.

Also, build time is improved by ~75 %. On my machine, main takes 66 seconds to build, but this branch only takes 38 seconds. I only did two runs (both from a clean repo) so perhaps this isn't very scientific.

@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 00:10 Inactive
@KnorpelSenf
Copy link
Member Author

If we want to have benchmarks we can trust, we should make sure to use version 1.5.0 of vitepress on master before we compare anything, so take the above numbers with a big grain of salt

@KnorpelSenf
Copy link
Member Author

Yeah I think it is rather caused by vitepress, #1143 seems to achieve similar results

@KnorpelSenf KnorpelSenf requested review from quadratz, rojvv, niusia-ua and Loskir and removed request for quadratz and rojvv November 5, 2024 00:26
@KnorpelSenf
Copy link
Member Author

ref vuejs/vitepress#4326

site/deno.jsonc Outdated
},
"tasks": {
"setup": "deno task docs:index-versions && deno task docs:genapi",
"docs:genapi": "cd api && deno task genapi",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should seize the opportunity and merge the two projects into one, but this can happen in a dedicated PQ because it's technically completely unrelated

@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 01:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 04:30 Inactive
@quadratz quadratz added not translatable Translator intervention is not required. chore Modifies or is related to tooling, configuration, or setup. labels Nov 5, 2024
@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 05:13 Inactive
@quadratz quadratz dismissed their stale review November 5, 2024 05:16

outdated

@rojvv rojvv added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit dc6e25c Nov 5, 2024
3 of 5 checks passed
@rojvv rojvv deleted the no-node branch November 5, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Modifies or is related to tooling, configuration, or setup. not translatable Translator intervention is not required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants