Skip to content

[audit-05] fix: [TRST-M-2] shared collection window logic #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: ma/indexing-payments-audit-fixes-04-M-1
Choose a base branch
from
Open

[audit-05] fix: [TRST-M-2] shared collection window logic #1202

wants to merge 1 commit into from
+79 −69

Conversation

matiasedgeandnode
Copy link
Contributor

Screenshot 2025-07-22 at 22 17 20

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jul 23, 2025 •
edited
Loading

[audit-05] fix: [TRST-M-2] shared collection window logic

Generated at commit: 345cfc8d6331e19e4e16900bde3b9348624b123c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-audit-fixes-04-M-1 branch from 3172bcd to 68508b6 Compare August 3, 2025 18:36
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-audit-fixes-05-M-2 branch from eec5ea6 to 17355fe Compare August 3, 2025 18:38
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-audit-fixes-04-M-1 branch from 68508b6 to 29dfdcc Compare August 3, 2025 19:23
@matiasedgeandnode
fix: [TRST-M-2] shared collection window logic
345cfc8 
Fixes TRST-M-2 audit finding:

Collection for an elapsed or canceled agreement could be wrong due to
temporal calculation inconsistencies between IndexingAgreement and
RecurringCollector layers.

* Replace isCollectable() with getCollectionInfo() that returns both collectability and duration
* Make RecurringCollector the single source of truth for temporal logic
* Update IndexingAgreement to call getCollectionInfo() once and pass duration to _tokensToCollect()
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-audit-fixes-05-M-2 branch from 17355fe to 345cfc8 Compare August 3, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcarranzav pcarranzav pcarranzav approved these changes

@tmigone tmigone Awaiting requested review from tmigone

@Maikol Maikol Awaiting requested review from Maikol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasedgeandnode @pcarranzav