Merged
Conversation
fix: added cancellableAt and LegacyDispute
…ake-lockeduntil
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
tmigone
reviewed
Jun 24, 2025
| let payer = createOrLoadPayer(event.params.payer) | ||
| let receiver = createOrLoadReceiver(event.params.receiver) | ||
| let escrow = createOrLoadEscrowAccount(event.params.payer, event.params.dataService, event.params.receiver) | ||
| escrow.balance = escrow.balance.minus(event.params.tokens) |
Member
There was a problem hiding this comment.
I think we should update the escrow as part of the payments escrow handlers, specifically in EscrowCollected handler as that is where the actual state is changed.
Member
There was a problem hiding this comment.
And we should add tokensCollected to the graph tally global state
Member
There was a problem hiding this comment.
Good point. My initial implementation was updating the balance in EscrowCollected, but that event doesn't have the collectionId so I changed it to PaymentCollected. But we can split it up, create the transaction here and update the escrow balance separately.
tmigone
reviewed
Jun 24, 2025
tmigone
reviewed
Jun 24, 2025
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
…phprotocol/graph-network-subgraph into juanmardefago/horizon-stage-1-signed
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.