-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subgraph composition: TriggersAdapterWrapper refactor #5602
Draft
incrypto32
wants to merge
10
commits into
subgraph-composition-interfacing
Choose a base branch
from
krishna/subgraph-composition-triggers-adapter-refactor
base: subgraph-composition-interfacing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Subgraph composition: TriggersAdapterWrapper refactor #5602
incrypto32
wants to merge
10
commits into
subgraph-composition-interfacing
from
krishna/subgraph-composition-triggers-adapter-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
August 15, 2024 12:45
6428449
to
548d11c
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
August 16, 2024 08:17
151779b
to
304e5df
Compare
incrypto32
changed the title
Subgraph Composition: TriggersAdapterWrapper Refactoring
Subgraph composition: TriggersAdapterWrapper refactor
Aug 19, 2024
incrypto32
force-pushed
the
subgraph-composition-interfacing
branch
from
September 12, 2024 08:07
548d11c
to
44c0385
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
September 12, 2024 08:09
b4ad24f
to
b35754e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just some refactoring of the TriggersAdapterWrapper to move some functionalities like scanning for subgraph triggers into its on functions